Performance

- moved turret index init to on_init
- migrated on_event to on_nth_tick
- typo in changelog

changelog.txt

@@ -1,8 +1,15 @@
 ---------------------------------------------------------------------------------------------------
+Version: 0.18.3
+Date: 2020-03-21
+  Changes:
+    - Migrated on_event to on_nth_tick for performance
+  Bugfixes:
+    - Added missing initialization of turret index
+---------------------------------------------------------------------------------------------------
 Version: 0.18.2
 Date: 2020-03-20
   Changes:
-    - Redesigned surface handling again to be more perfomant
+    - Redesigned surface handling again to be more performant
 ---------------------------------------------------------------------------------------------------
 Version: 0.18.1
 Date: 2020-03-19

control.lua

@@ -1,15 +1,19 @@
 --control.lua
 --This mod scans the map for gun-turrets and places alerts when turrets are low. 
 
-script.on_event({defines.events.on_tick}, function (event)
+script.on_init(function (event)
+	-- turret index init
+	global.turret_entities = {}
+end)
+
+script.on_nth_tick(3600, function (event)
 	--Every minute the surface is rescanned for ammo-turret type entities. This is stored in the global table. 
-	if event.tick%3600 == 0 or global.turret_entities == nil then
-		local planet = game.surfaces
-		for index,_ in pairs(planet) do
-			global.turret_entities[index] = planet[index].find_entities_filtered{type = "ammo-turret"}
+	for index,surface in pairs(game.surfaces) do
+		global.turret_entities[index] = surface.find_entities_filtered{type = "ammo-turret"}
 	end
-	end
-	if event.tick%600 == 0 then
+end)
+
+script.on_nth_tick(600, function (event)
 	--Every 10 seconds recheck and give alerts to players for ammo-turret entities on the same force as them. 
 	for _,player in pairs(game.connected_players) do
 		
@@ -32,5 +36,4 @@ script.on_event({defines.events.on_tick}, function (event)
 			end
 		end
 	end
-	end
 end)

info.json

@@ -1,6 +1,6 @@
 {
     "name": "Gun_Turret_Alerts",
-    "version": "0.18.2",
+    "version": "0.18.3",
     "title": "Gun_Turret_Alerts",
     "author": "Wyrrrd",
     "factorio_version": "0.18",